change behaviour on too large argument

Move msg_count handling to hello2 to comply with lab5 requirements

Makefile

@@ -1,13 +1,18 @@
 
 ifneq ($(KERNELRELEASE),)
 # kbuild part of makefile
-obj-m   := hello.o
+obj-m   := hello1.o hello2.o
+ccflags-y := -I$(obj)/inc -g
 else
 # normal makefile
 KDIR ?= /lib/modules/`uname -r`/build
 
 default:
 	$(MAKE) -C $(KDIR) M=$$PWD
+	cp hello1.ko hello1.ko.unstripped
+	$(CROSS_COMPILE)strip -g hello1.ko
+
 clean:
 	$(MAKE) -C $(KDIR) M=$$PWD clean
+
 endif

hello1.c

@@ -40,94 +40,93 @@ MODULE_LICENSE("Dual BSD/GPL");
 
 struct TimingList {
 	struct TimingList *next;
-	ktime_t t;
+	ktime_t t_before;
+	ktime_t t_after;
 };
 
-static unsigned int msg_count = 1;
 static struct TimingList *tl_head;
+static unsigned int bug_generator;
 
-static void init_new_list(void)
+static struct TimingList *write_first_node(void)
 {
 	tl_head = kmalloc(sizeof(struct TimingList), GFP_KERNEL);
-
 	tl_head->next = NULL;
-	tl_head->t = ktime_get();
+
+	return tl_head;
 }
 
-static void insert_new_time(void)
+static struct TimingList *insert_next_node(struct TimingList *tail)
 {
-	struct TimingList *last_tl_node = tl_head;
 	struct TimingList *new_tl_node = kmalloc(sizeof(struct TimingList),
 						GFP_KERNEL);
 
-	while (last_tl_node->next != NULL)
-		last_tl_node = last_tl_node->next;
+	if (bug_generator == 2) {
+		new_tl_node = NULL;
+	} else {
+		tail->next = new_tl_node;
+		new_tl_node->next = NULL;
+	}
 
-
-	new_tl_node->next = NULL;
-	new_tl_node->t = ktime_get();
-
-	last_tl_node->next = new_tl_node;
+	return new_tl_node;
 }
 
-static void print_time(ktime_t *t)
+static struct TimingList *add_new_node(struct TimingList *tail)
 {
-	printk(KERN_EMERG "%lld\n", *t);
+	if (tail == NULL)
+		return write_first_node();
+	else
+		return insert_next_node(tail);
 }
 
-static void destroy_list(void)
+static void print_time_diff(struct TimingList *node)
+{
+	pr_info("%lld\n", node->t_after - node->t_before);
+}
+
+void destroy_list(void)
 {
 	struct TimingList *curr_tl = tl_head;
 	struct TimingList *next_tl = NULL;
 
+	tl_head = NULL;
+
 	while (curr_tl != NULL) {
-		print_time(&(curr_tl->t));
+		print_time_diff(curr_tl);
 
 		next_tl = curr_tl->next;
 		kfree(curr_tl);
 		curr_tl = next_tl;
 	}
 }
-
-static void update_timing_list(void)
-{
-	if (tl_head == NULL)
-		init_new_list();
-	else
-		insert_new_time();
-}
+EXPORT_SYMBOL(destroy_list);
 
 static int __init hello_init(void)
 {
-	int i;
-
-	if (msg_count > 10) {
-		printk(KERN_EMERG "Error: msg_count too large (%d > 10)\n",
-				msg_count);
-		return -EINVAL;
-	}
-
-	if (msg_count == 0 || msg_count >= 5) {
-		printk(KERN_EMERG "Warning: msg_count = %d (msg_count == 0 or 5 <= msg_count <= 10)\n",
-				msg_count);
-	}
-
-	for (i = 0; i < msg_count; i++) {
-		update_timing_list();
-
-		printk(KERN_EMERG "Hello, world!\n");
-	}
-
 	return 0;
 }
 
+void print_hello(int msg_count)
+{
+	int i;
+	struct TimingList *current_tail = tl_head;
+
+	for (i = 0; i < msg_count; i++) {
+		bug_generator = i;
+
+		current_tail = add_new_node(current_tail);
+
+		current_tail->t_before = ktime_get();
+		pr_info("Hello, world!\n");
+		current_tail->t_after = ktime_get();
+	}
+}
+EXPORT_SYMBOL(print_hello);
+
 static void __exit hello_exit(void)
 {
 	destroy_list();
 }
 
-module_param(msg_count, uint, 0444);
-MODULE_PARM_DESC(msg_count, "Amount of hello world outputs on load");
 
 module_init(hello_init);
 module_exit(hello_exit);

hello2.c

@@ -0,0 +1,65 @@
+
+/*
+ * Copyright (c) 2017, GlobalLogic Ukraine LLC
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ * 3. All advertising materials mentioning features or use of this software
+ *    must display the following acknowledgement:
+ *    This product includes software developed by the GlobalLogic.
+ * 4. Neither the name of the GlobalLogic nor the
+ *    names of its contributors may be used to endorse or promote products
+ *    derived from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY GLOBALLOGIC UKRAINE LLC ``AS IS`` AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL GLOBALLOGIC UKRAINE LLC BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <linux/init.h>
+#include <linux/module.h>
+#include <linux/printk.h>
+#include <linux/slab.h>
+
+#include "hello1.h"
+
+MODULE_AUTHOR("Serhii Popovych <serhii.popovych@globallogic.com>");
+MODULE_DESCRIPTION("Hello, world in Linux Kernel Training");
+MODULE_LICENSE("Dual BSD/GPL");
+
+static unsigned int msg_count = 1;
+
+static int __init hello_init(void)
+{
+	BUG_ON(msg_count > 10);
+
+	if (msg_count == 0 || msg_count >= 5)
+		pr_warn("Warning: msg_count = %d (msg_count == 0 or 5 <= msg_count <= 10)\n", msg_count);
+
+	print_hello(msg_count);
+	return 0;
+}
+
+static void __exit hello_exit(void)
+{
+	destroy_list();
+}
+
+module_param(msg_count, uint, 0444);
+MODULE_PARM_DESC(msg_count, "Amount of hello world outputs on load");
+
+module_init(hello_init);
+module_exit(hello_exit);

inc/hello1.h

@@ -0,0 +1,2 @@
+void print_hello(int msg_count);
+void destroy_list(void);

test.sh

@@ -0,0 +1,18 @@
+#!/bin/sh
+
+if [ -z "$1" ]; then
+	echo "Error: no script supplied"
+	echo "Usage: $0 path/to/testing/script"
+	exit 1
+fi
+
+while read l; do
+	if [ -z "$l" ]; then
+		continue;
+	fi;
+
+	echo "$ $l";
+	$($l);
+
+	echo -e ""
+done < $1

tests/lab5-test

@@ -0,0 +1,33 @@
+insmod hello2.ko
+
+insmod hello1.ko
+
+insmod hello2.ko
+rmmod hello2.ko
+
+insmod hello2.ko msg_count=0
+rmmod hello2.ko
+
+insmod hello2.ko msg_count=1
+rmmod hello2.ko
+
+insmod hello2.ko msg_count=3
+rmmod hello2.ko
+
+insmod hello2.ko msg_count=5
+rmmod hello2.ko
+
+insmod hello2.ko msg_count=8
+rmmod hello2.ko
+
+insmod hello2.ko msg_count=10
+rmmod hello2.ko
+
+insmod hello2.ko msg_count=12
+rmmod hello2.ko
+
+insmod hello2.ko
+rmmod hello1.ko
+
+rmmod hello2.ko
+rmmod hello1.ko