hasslesstech/IoT-Systems
1
0
Fork 0
Code Issues Pull Requests Actions Activity

FileReader #5

Merged
bacant150 merged 15 commits from lab1_huranets into lab1 2026-02-26 10:04:10 +02:00
Conversation 34 Commits 15 Files Changed 3 +3 -11
1 changed files with 3 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a25fbfc3ef - Show all commits

14
agent/src/file_datasource.py
View File

@@ -14,7 +14,6 @@ import config
class FileDatasource: class FileDatasource:
def __init__(self, accelerometer_filename: str, gps_filename: str) -> None: def __init__(self, accelerometer_filename: str, gps_filename: str) -> None:
self.accelerometer_filename = accelerometer_filename self.accelerometer_filename = accelerometer_filename
self.gps_filename = gps_filename self.gps_filename = gps_filename
@@ -200,21 +199,14 @@ class FileDatasource:
# Otherwise treat it as header-ish (skip it) # Otherwise treat it as header-ish (skip it)
hasslesstech commented 2026-02-24 20:17:50 +02:00 (Migrated from github.com)
Review
Copy Link

Removal of checks is not neccesary, but is plausible since the source file should only contain correct data

Removal of checks is not neccesary, but is plausible since the source file *should* only contain correct data
bacant150 commented 2026-02-24 20:50:52 +02:00 (Migrated from github.com)
Review
Copy Link

Resumed checks

Resumed checks
return True, None return True, None
@staticmethod
def _parse_int(s: str) -> int:
return int(s)
@staticmethod @staticmethod
hasslesstech commented 2026-02-24 15:25:56 +02:00 (Migrated from github.com)
Review
Copy Link

This value range check might break future integration with higher precision accelerometer data, hence should be removed

This value range check might break future integration with higher precision accelerometer data, hence should be removed
def _parse_acc(row: List[str]) -> Accelerometer: def _parse_acc(row: List[str]) -> Accelerometer:
if len(row) < 3: if len(row) < 3:
raise ValueError(f"Accelerometer row must have 3 values (x,y,z). Got: {row}") raise ValueError(f"Accelerometer row must have 3 values (x,y,z). Got: {row}")
try: x = int(row[0])
x = int(row[0]) y = int(row[1])
y = int(row[1]) z = int(row[2])
z = int(row[2])
except ValueError as e:
raise ValueError(f"Invalid accelerometer values (expected integers): {row}") from e
return Accelerometer(x=x, y=y, z=z) return Accelerometer(x=x, y=y, z=z)