Compare commits

..

33 Commits

Author SHA1 Message Date
23a11ec102 [P] Remove uncessecary empty line
All checks were successful
Component testing / Hub testing (push) Successful in 25s
Component testing / Store testing (push) Successful in 26s
Component testing / Integration smoke testing (push) Successful in 3m35s
2026-03-27 18:40:11 +02:00
ad3c336ecf [P] Send only visible records from store on websocket connection
All checks were successful
Component testing / Hub testing (push) Successful in 21s
Component testing / Store testing (push) Successful in 26s
Component testing / Integration smoke testing (push) Successful in 2m36s
2026-03-27 18:38:22 +02:00
5c3010dcfe [P] Remove user_id from store <-> mapview interaction, fix update_db_record 2026-03-27 18:24:53 +02:00
712691f3d2 [P] Sync the async function 2026-03-27 18:15:56 +02:00
f5486f0469 [P] Add database update after marker deletion.
All checks were successful
Component testing / Hub testing (push) Successful in 23s
Component testing / Store testing (push) Successful in 34s
Component testing / Integration smoke testing (push) Successful in 2m54s
2026-03-27 16:41:39 +01:00
51fca8436a [P] Code cleanup. 2026-03-27 16:41:39 +01:00
c5f6fbf7af [L4] Fix relative module imports 2026-03-27 16:41:39 +01:00
SimonSanich
7b02884b10 Add test for new records in DB 2026-03-27 16:41:38 +01:00
6850454711 [P] Fix several crashes triggered in one call sequence 2026-03-27 16:40:21 +01:00
abbc703b1b [P] Improve marker removal architecture to allow for future extensions 2026-03-27 16:40:21 +01:00
79a58f1737 [P] Add touch handling (untested). 2026-03-27 16:40:21 +01:00
39fca87025 Correct pothole deletion function 2026-03-27 16:40:21 +01:00
3bc39e011d Use lat lon validation 2026-03-27 16:40:21 +01:00
b2780c1c6b Add lat lon to pothole mapper 2026-03-27 16:40:21 +01:00
1e607729e2 Add type hints 2026-03-27 16:40:21 +01:00
8dc8a1f4ba [P] Add bump remove function 2026-03-27 16:40:21 +01:00
a578a96347 Merge branch 'github/dev' into dev
All checks were successful
Component testing / Hub testing (push) Successful in 24s
Component testing / Store testing (push) Successful in 35s
Component testing / Integration smoke testing (push) Successful in 2m51s
2026-03-27 16:28:41 +02:00
VladiusVostokus
5749dd825f Merge pull request #30 from Rhinemann/lab4/gryshaiev-SCRUM-82-test-new-records-in-db
Add test for new records in DB
2026-03-27 16:14:51 +02:00
86c6c14502 [L4] Correct road state string 2026-03-27 16:03:41 +02:00
561004a49c [L4] Fix relative module imports 2026-03-27 16:03:38 +02:00
SimonSanich
7d75a15de1 Add test for new records in DB 2026-03-27 15:14:17 +02:00
ІМ-24 Владислав Коваленко
eca98c4469 fix: actually use session variable in websocket GET
All checks were successful
Component testing / Hub testing (push) Successful in 23s
Component testing / Store testing (push) Successful in 24s
Component testing / Integration smoke testing (push) Successful in 2m42s
2026-03-26 16:52:00 +00:00
ІМ-24 Владислав Коваленко
c553384ce7 fix: add session rollback in DELETE
All checks were successful
Component testing / Hub testing (push) Successful in 17s
Component testing / Store testing (push) Successful in 28s
Component testing / Integration smoke testing (push) Successful in 2m44s
2026-03-26 15:59:57 +00:00
ІМ-24 Владислав Коваленко
1bf5687505 fix: add session rollback in PUT 2026-03-26 15:56:34 +00:00
ІМ-24 Владислав Коваленко
0d9dcef994 fix: close connection after GET in websocket 2026-03-26 15:52:33 +00:00
ІМ-24 Владислав Коваленко
d073243c67 refactor: use try block for error handling and session rollback
All checks were successful
Component testing / Hub testing (push) Successful in 23s
Component testing / Store testing (push) Successful in 30s
Component testing / Integration smoke testing (push) Successful in 2m28s
2026-03-26 14:07:37 +00:00
ІМ-24 Владислав Коваленко
0d364ddf61 fix: remove visibility update from PUT endpoint 2026-03-26 14:07:37 +00:00
ІМ-24 Владислав Коваленко
05c94bda81 feat: update visibility field with websocket 2026-03-26 14:07:37 +00:00
ІМ-24 Владислав Коваленко
26230df612 feat: add schema for receiving data from websocker 2026-03-26 14:07:37 +00:00
ІМ-24 Владислав Коваленко
ae10e212cb fix: remove visible from schemas, so only store knows about it 2026-03-26 14:07:37 +00:00
ІМ-24 Владислав Коваленко
e2e68e8506 fix: add visible columnt to .sql init script 2026-03-26 14:07:37 +00:00
ІМ-24 Владислав Коваленко
1375e6e4be feat: add visibility field to database table 2026-03-26 14:07:37 +00:00
ІМ-24 Владислав Коваленко
154c5c3a78 feat: add visibility field 2026-03-26 14:07:37 +00:00
6 changed files with 184 additions and 32 deletions

View File

@@ -9,6 +9,7 @@ from config import STORE_HOST, STORE_PORT
# Pydantic models # Pydantic models
class ProcessedAgentData(BaseModel): class ProcessedAgentData(BaseModel):
id: int
road_state: str road_state: str
user_id: int user_id: int
x: float x: float
@@ -32,11 +33,12 @@ class ProcessedAgentData(BaseModel):
class Datasource: class Datasource:
def __init__(self, user_id: int): def __init__(self):
self.websocket: Connection | None = None
self.index = 0 self.index = 0
self.user_id = user_id
self.connection_status = None self.connection_status = None
self._new_points = [] self._new_points = []
self._active_markers = []
asyncio.ensure_future(self.connect_to_server()) asyncio.ensure_future(self.connect_to_server())
def get_new_points(self): def get_new_points(self):
@@ -46,11 +48,12 @@ class Datasource:
return points return points
async def connect_to_server(self): async def connect_to_server(self):
uri = f"ws://{STORE_HOST}:{STORE_PORT}/ws/{self.user_id}" uri = f"ws://{STORE_HOST}:{STORE_PORT}/ws"
while True: while True:
Logger.debug("CONNECT TO SERVER") Logger.debug("CONNECT TO SERVER")
async with websockets.connect(uri) as websocket: async with websockets.connect(uri) as websocket:
self.connection_status = "Connected" self.connection_status = "Connected"
self.websocket = websocket
try: try:
while True: while True:
data = await websocket.recv() data = await websocket.recv()
@@ -60,6 +63,26 @@ class Datasource:
self.connection_status = "Disconnected" self.connection_status = "Disconnected"
Logger.debug("SERVER DISCONNECT") Logger.debug("SERVER DISCONNECT")
def update_db_record_visibility(self, record_id):
if self.websocket:
data = json.dumps({"id": record_id})
asyncio.ensure_future(self.websocket.send(data))
def map_lat_lon_to_processed_agent_data(self, lat: float, lon: float) -> ProcessedAgentData | None:
distances = tuple((abs(lon - marker.latitude) ** 2 + abs(lat - marker.longitude) ** 2) ** 0.5 for marker in
self._active_markers)
if len(distances) == 0:
return None
min_distance = min(distances)
marker = self._active_markers[distances.index(min_distance)]
if min_distance < 0.005:
return marker
else:
return None
def handle_received_data(self, data): def handle_received_data(self, data):
# Update your UI or perform actions with received data here # Update your UI or perform actions with received data here
Logger.debug(f"Received data: {data}") Logger.debug(f"Received data: {data}")
@@ -70,6 +93,9 @@ class Datasource:
], ],
key=lambda v: v.timestamp, key=lambda v: v.timestamp,
) )
self._active_markers += [i for i in processed_agent_data_list if i.road_state != 'normal']
new_points = [ new_points = [
( (
processed_agent_data.longitude, processed_agent_data.longitude,

View File

@@ -15,18 +15,31 @@ line_layer_colors = [
[1, 0, 1, 1], [1, 0, 1, 1],
] ]
def get_lat_lon(point: dict[str, float] | list[float] | tuple[float, float]) -> tuple[float, float] | None:
if isinstance(point, dict):
lat = point.get("lat")
lon = point.get("lon")
else:
lat, lon = point
if lat is None or lon is None:
return None
return lat, lon
class MapViewApp(App): class MapViewApp(App):
def __init__(self, **kwargs): def __init__(self, **kwargs):
super().__init__(**kwargs) super().__init__(**kwargs)
self.mapview = None self.mapview: MapView | None = None
self.datasource = Datasource(user_id=1) self.datasource = Datasource()
self.line_layers = dict() self.line_layers = dict()
self.car_markers = dict() self.car_markers = dict()
# додати необхідні змінні # додати необхідні змінні
self.bump_markers = [] self.bump_markers: list[MapMarker] = []
self.pothole_markers = [] self.pothole_markers: list[MapMarker] = []
def on_start(self): def on_start(self):
""" """
@@ -50,7 +63,7 @@ class MapViewApp(App):
# Оновлює лінію маршрута # Оновлює лінію маршрута
if user_id not in self.line_layers: if user_id not in self.line_layers:
self.line_layers[user_id] = LineMapLayer(color = line_layer_colors[user_id % len(line_layer_colors)]) self.line_layers[user_id] = LineMapLayer(color=line_layer_colors[user_id % len(line_layer_colors)])
self.mapview.add_layer(self.line_layers[user_id]) self.mapview.add_layer(self.line_layers[user_id])
self.line_layers[user_id].add_point((lat, lon)) self.line_layers[user_id].add_point((lat, lon))
@@ -91,13 +104,16 @@ class MapViewApp(App):
if user_id == config.TRACK_ID: if user_id == config.TRACK_ID:
self.mapview.center_on(lat, lon) self.mapview.center_on(lat, lon)
def set_pothole_marker(self, point): def map_lat_lon_to_marker(self, lat: float, lon: float) -> MapMarker | None:
if isinstance(point, dict): flt = filter(lambda marker: lon == marker.lat and lat == marker.lon, self.pothole_markers + self.bump_markers)
lat = point.get("lat")
lon = point.get("lon")
else:
lat, lon = point
try:
return next(flt)
except StopIteration:
return None
def set_pothole_marker(self, point):
lat, lon = get_lat_lon(point)
if lat is None or lon is None: if lat is None or lon is None:
return return
@@ -111,24 +127,48 @@ class MapViewApp(App):
self.pothole_markers.append(marker) self.pothole_markers.append(marker)
def set_bump_marker(self, point): def set_bump_marker(self, point):
if isinstance(point, dict): lat, lon = get_lat_lon(point)
lat = point.get("lat")
lon = point.get("lon")
else:
lat, lon = point
if lat is None or lon is None: if lat is None or lon is None:
return return
marker = MapMarker( marker = MapMarker(
lat=lat, lat=lat,
lon=lon, lon=lon,
source="images/bump.png" source="images/bump.png"
) )
self.mapview.add_marker(marker) self.mapview.add_marker(marker)
self.bump_markers.append(marker) self.bump_markers.append(marker)
def delete_pothole_marker(self, point):
lat, lon = get_lat_lon(point)
if lat is None or lon is None:
return
clicked_marker_data = self.datasource.map_lat_lon_to_processed_agent_data(lat, lon)
if not clicked_marker_data:
return
clicked_marker = self.map_lat_lon_to_marker(clicked_marker_data.latitude, clicked_marker_data.longitude)
if clicked_marker is None:
return
self.mapview.remove_marker(clicked_marker)
if clicked_marker in self.pothole_markers:
self.pothole_markers.pop(self.pothole_markers.index(clicked_marker))
elif clicked_marker in self.bump_markers:
self.bump_markers.pop(self.bump_markers.index(clicked_marker))
self.datasource.update_db_record_visibility(clicked_marker_data.id)
def on_touch_down(self, widget, touch):
if touch.button == "right":
coordinate = self.mapview.get_latlon_at(touch.x, touch.y, self.mapview.zoom)
self.delete_pothole_marker(coordinate)
return True
def build(self): def build(self):
""" """
@@ -141,6 +181,8 @@ class MapViewApp(App):
lon=30.5234 lon=30.5234
) )
self.mapview.bind(on_touch_down=self.on_touch_down)
return self.mapview return self.mapview

View File

@@ -7,5 +7,6 @@ CREATE TABLE processed_agent_data (
z FLOAT, z FLOAT,
latitude FLOAT, latitude FLOAT,
longitude FLOAT, longitude FLOAT,
timestamp TIMESTAMP timestamp TIMESTAMP,
); visible BOOLEAN
);

View File

@@ -8,12 +8,13 @@ from sqlalchemy import (
Integer, Integer,
String, String,
Float, Float,
Boolean,
DateTime, DateTime,
) )
from sqlalchemy.sql import select from sqlalchemy.sql import select
from database import metadata, SessionLocal from database import metadata, SessionLocal
from schemas import ProcessedAgentData, ProcessedAgentDataInDB from schemas import ProcessedAgentData, ProcessedAgentDataInDB, WebSocketData
# FastAPI app setup # FastAPI app setup
app = FastAPI() app = FastAPI()
@@ -30,6 +31,7 @@ processed_agent_data = Table(
Column("latitude", Float), Column("latitude", Float),
Column("longitude", Float), Column("longitude", Float),
Column("timestamp", DateTime), Column("timestamp", DateTime),
Column("visible", Boolean),
) )
# WebSocket subscriptions # WebSocket subscriptions
@@ -37,16 +39,21 @@ subscriptions: Set[WebSocket] = set()
# FastAPI WebSocket endpoint # FastAPI WebSocket endpoint
@app.websocket("/ws/{user_id}") @app.websocket("/ws")
async def websocket_endpoint(websocket: WebSocket, user_id: int): async def websocket_endpoint(websocket: WebSocket):
await websocket.accept() await websocket.accept()
subscriptions.add(websocket) subscriptions.add(websocket)
try: try:
# send already available data # send already available data
r = processed_agent_data.select().order_by(processed_agent_data.c.timestamp) r = processed_agent_data.select() \
stored_data = SessionLocal().execute(r).fetchall() .where(processed_agent_data.c.visible == True) \
.order_by(processed_agent_data.c.timestamp)
session = SessionLocal()
stored_data = session.execute(r).fetchall()
session.close()
jsonable_data = [{c.name: getattr(i, c.name) for c in processed_agent_data.columns} for i in stored_data] jsonable_data = [{c.name: getattr(i, c.name) for c in processed_agent_data.columns} for i in stored_data]
for i in jsonable_data: for i in jsonable_data:
@@ -57,7 +64,24 @@ async def websocket_endpoint(websocket: WebSocket, user_id: int):
# receive forever # receive forever
while True: while True:
await websocket.receive_text() data = await websocket.receive_text()
try:
if (data):
ws_data = WebSocketData.model_validate(json.loads(data))
session = SessionLocal()
update_query = (
processed_agent_data.update()
.where(processed_agent_data.c.id == ws_data.id)
.values(visible=False)
).returning(processed_agent_data)
res = session.execute(update_query).fetchone()
if (not res):
session.rollback()
raise Exception("Error while websocket PUT")
session.commit()
finally:
session.close()
except WebSocketDisconnect: except WebSocketDisconnect:
subscriptions.remove(websocket) subscriptions.remove(websocket)
@@ -81,6 +105,7 @@ def ProcessedAgentData_to_td(data: List[ProcessedAgentData]):
"latitude": item.agent_data.gps.latitude, "latitude": item.agent_data.gps.latitude,
"longitude": item.agent_data.gps.longitude, "longitude": item.agent_data.gps.longitude,
"timestamp": item.agent_data.timestamp, "timestamp": item.agent_data.timestamp,
"visible": True,
} }
for item in data for item in data
] ]
@@ -178,8 +203,12 @@ def update_processed_agent_data(processed_agent_data_id: int, data: ProcessedAge
session.commit() session.commit()
updated_result = session.execute(query).fetchone() updated_result = session.execute(query).fetchone()
return ProcessedAgentDataInDB(**updated_result._mapping) return ProcessedAgentDataInDB(**updated_result._mapping)
except Exception as err:
session.rollback()
print(f"Database error: {err}")
raise HTTPException(status_code=500, detail="Internal Server Error")
finally: finally:
session.close() session.close()
@@ -210,7 +239,12 @@ def delete_processed_agent_data(processed_agent_data_id: int):
session.commit() session.commit()
return ProcessedAgentDataInDB(**result._mapping) return ProcessedAgentDataInDB(**result._mapping)
except Exception as err:
session.rollback()
print(f"Database error: {err}")
raise HTTPException(status_code=500, detail="Internal Server Error")
finally: finally:
session.close() session.close()

View File

@@ -49,3 +49,7 @@ class AgentData(BaseModel):
class ProcessedAgentData(BaseModel): class ProcessedAgentData(BaseModel):
road_state: str road_state: str
agent_data: AgentData agent_data: AgentData
class WebSocketData(BaseModel):
id: int

45
store/test_db.py Normal file
View File

@@ -0,0 +1,45 @@
from fastapi.testclient import TestClient
from main import app, processed_agent_data
from database import SessionLocal
from sqlalchemy import select
from datetime import datetime
client = TestClient(app)
def test_create_processed_agent_data():
db = SessionLocal()
before = db.execute(select(processed_agent_data)).fetchall()
before_count = len(before)
payload = {
"user_id": 123,
"data": [
{
"road_state": "good",
"agent_data": {
"user_id": 999,
"accelerometer": {
"x": 1.1,
"y": 2.2,
"z": 3.3
},
"gps": {
"latitude": 50.45,
"longitude": 30.52
},
"timestamp": datetime.now().isoformat()
}
}
]
}
response = client.post("/processed_agent_data/", json=payload)
assert response.status_code == 200
after = db.execute(select(processed_agent_data)).fetchall()
after_count = len(after)
assert after_count == before_count + 1
db.close()